linux-kernel - Re: [PATCH 3/3] hwrng: ba431-rng: add support for BA431 hwrng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3=HoQZuBoqyFgyde1X7BRfcH-GFQpu=8acOi_JhVU99g@mail.gmail.com>
Date:   Mon, 25 May 2020 22:28:46 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Olivier Sobrie <olivier.sobrie@...exinsight.com>
Cc:     Matt Mackall <mpm@...enic.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Rob Herring <robh+dt@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@...r.kernel.org>, DTML <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Waleed Ziad <waleed94ziad@...il.com>,
        sebastien.rabou@...exinsight.com
Subject: Re: [PATCH 3/3] hwrng: ba431-rng: add support for BA431 hwrng

On Mon, May 25, 2020 at 10:07 PM Olivier Sobrie
<olivier.sobrie@...exinsight.com> wrote:
>
> Silex insight BA431 is an IP designed to generate random numbers that
> can be integrated in various FPGA.
> This driver adds support for it through the hwrng interface.
>
> This driver is used in Silex Insight Viper OEM boards.
>
> Signed-off-by: Olivier Sobrie <olivier.sobrie@...exinsight.com>
> Signed-off-by: Waleed Ziad <waleed94ziad@...il.com>

The driver looks good to me.

Acked-by: Arnd Bergmann  <arnd@...db.de>

>  drivers/char/hw_random/Kconfig     |  10 ++
>  drivers/char/hw_random/Makefile    |   1 +
>  drivers/char/hw_random/ba431-rng.c | 240 +++++++++++++++++++++++++++++

I wonder if we should move drivers/char/hw_random to its own top-level drivers
subsystem outside of drivers/char. It seems to be growing steadily and is larger
than a lot of other subsystems with currently 34 drivers in there.

Not your problem though.

> +       /* Wait until the state changed */
> +       for (i = 0; i < BA431_RESET_READ_STATUS_RETRIES; ++i) {
> +               state = ba431_trng_get_state(ba431);
> +               if (state >= BA431_STATE_STARTUP)
> +                       break;
> +
> +               udelay(BA431_RESET_READ_STATUS_INTERVAL);
> +       }

Looking for something to improve, I noticed that this loop can take over
a millisecond to time out, and it always runs in non-atomic context.
It may be better to use usleep_range() than udelay().

      Arnd