linux-kernel - Re: [PATCH v2 16/18] nitro_enclaves: Add sample for ioctl interface usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af35ad60-6084-b28d-60ec-4e27adfae800@amazon.com>
Date:   Tue, 26 May 2020 00:10:06 +0300
From:   "Paraschiv, Andra-Irina" <andraprs@...zon.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     <linux-kernel@...r.kernel.org>,
        Anthony Liguori <aliguori@...zon.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Colm MacCarthaigh <colmmacc@...zon.com>,
        Bjoern Doebel <doebel@...zon.de>,
        David Woodhouse <dwmw@...zon.co.uk>,
        Frank van der Linden <fllinden@...zon.com>,
        "Alexander Graf" <graf@...zon.de>,
        Martin Pohlack <mpohlack@...zon.de>,
        Matt Wilson <msw@...zon.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Balbir Singh <sblbir@...zon.com>,
        Stefano Garzarella <sgarzare@...hat.com>,
        "Stefan Hajnoczi" <stefanha@...hat.com>,
        Stewart Smith <trawets@...zon.com>,
        "Uwe Dannowski" <uwed@...zon.de>, <kvm@...r.kernel.org>,
        <ne-devel-upstream@...zon.com>
Subject: Re: [PATCH v2 16/18] nitro_enclaves: Add sample for ioctl interface
 usage



On 22/05/2020 10:11, Greg KH wrote:
> On Fri, May 22, 2020 at 09:29:44AM +0300, Andra Paraschiv wrote:
>> Signed-off-by: Alexandru Vasile <lexnv@...zon.com>
>> Signed-off-by: Andra Paraschiv <andraprs@...zon.com>
> No changelog?

I included the changelog in v3.

>
>> ---
>>   samples/nitro_enclaves/.gitignore             |   2 +
>>   samples/nitro_enclaves/Makefile               |  28 +
>>   .../include/linux/nitro_enclaves.h            |  23 +
>>   .../include/uapi/linux/nitro_enclaves.h       |  77 +++
> Why are you not using the uapi files from the kernel itself?  How are
> you going to keep these in sync?

Yeah, the uapi files should be used, I just removed the include folder 
from here.

Thank you.

Andra



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.