linux-kernel - Re: [PATCH] drivers: ipa: print dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75dd9de2-c8a8-945a-fb14-26c3c6044bb6@ieee.org>
Date:   Mon, 25 May 2020 19:49:25 -0500
From:   Alex Elder <elder@...e.org>
To:     Wang Wenhu <wenhu.wang@...o.com>, davem@...emloft.net,
        elder@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     kernel@...o.com
Subject: Re: [PATCH] drivers: ipa: print dev_err info accurately

On 5/25/20 1:29 AM, Wang Wenhu wrote:
> Print certain name string instead of hard-coded "memory" for dev_err
> output, which would be more accurate and helpful for debugging.
> 
> Signed-off-by: Wang Wenhu <wenhu.wang@...o.com>
> Cc: Alex Elder <elder@...nel.org>

Good idea.

Reviewed-by: Alex Elder <elder@...aro.org>

> ---
>   drivers/net/ipa/ipa_clock.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c
> index ddbd687fe64b..749ff5668e37 100644
> --- a/drivers/net/ipa/ipa_clock.c
> +++ b/drivers/net/ipa/ipa_clock.c
> @@ -66,8 +66,8 @@ ipa_interconnect_init_one(struct device *dev, const char *name)
>   
>   	path = of_icc_get(dev, name);
>   	if (IS_ERR(path))
> -		dev_err(dev, "error %ld getting memory interconnect\n",
> -			PTR_ERR(path));
> +		dev_err(dev, "error %ld getting %s interconnect\n",
> +			PTR_ERR(path), name);
>   
>   	return path;
>   }
>