lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 May 2020 20:53:05 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Aymeric Agon-Rambosson <aymeric.agon@...dex.com>, Andrew Morton <akpm@...ux-foundation.org>, Stephen Boyd <swboyd@...omium.org>, Jan Kiszka <jan.kiszka@...mens.com>, Kieran Bingham <kbingham@...nel.org>, Douglas Anderson <dianders@...omium.org>, Nikolay Borisov <n.borisov.lkml@...il.com>, Jackie Liu <liuyun01@...inos.cn>, Jason Wessel <jason.wessel@...driver.com>, Linus Torvalds <torvalds@...ux-foundation.org>, Sasha Levin <sashal@...nel.org> Subject: [PATCH 5.4 047/111] scripts/gdb: repair rb_first() and rb_last() From: Aymeric Agon-Rambosson <aymeric.agon@...dex.com> [ Upstream commit 50e36be1fb9572b2e4f2753340bdce3116bf2ce7 ] The current implementations of the rb_first() and rb_last() gdb functions have a variable that references itself in its instanciation, which causes the function to throw an error if a specific condition on the argument is met. The original author rather intended to reference the argument and made a typo. Referring the argument instead makes the function work as intended. Signed-off-by: Aymeric Agon-Rambosson <aymeric.agon@...dex.com> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> Reviewed-by: Stephen Boyd <swboyd@...omium.org> Cc: Jan Kiszka <jan.kiszka@...mens.com> Cc: Kieran Bingham <kbingham@...nel.org> Cc: Douglas Anderson <dianders@...omium.org> Cc: Nikolay Borisov <n.borisov.lkml@...il.com> Cc: Jackie Liu <liuyun01@...inos.cn> Cc: Jason Wessel <jason.wessel@...driver.com> Link: http://lkml.kernel.org/r/20200427051029.354840-1-aymeric.agon@yandex.com Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org> Signed-off-by: Sasha Levin <sashal@...nel.org> --- scripts/gdb/linux/rbtree.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/gdb/linux/rbtree.py b/scripts/gdb/linux/rbtree.py index 39db889b874c..c4b991607917 100644 --- a/scripts/gdb/linux/rbtree.py +++ b/scripts/gdb/linux/rbtree.py @@ -12,7 +12,7 @@ rb_node_type = utils.CachedType("struct rb_node") def rb_first(root): if root.type == rb_root_type.get_type(): - node = node.address.cast(rb_root_type.get_type().pointer()) + node = root.address.cast(rb_root_type.get_type().pointer()) elif root.type != rb_root_type.get_type().pointer(): raise gdb.GdbError("Must be struct rb_root not {}".format(root.type)) @@ -28,7 +28,7 @@ def rb_first(root): def rb_last(root): if root.type == rb_root_type.get_type(): - node = node.address.cast(rb_root_type.get_type().pointer()) + node = root.address.cast(rb_root_type.get_type().pointer()) elif root.type != rb_root_type.get_type().pointer(): raise gdb.GdbError("Must be struct rb_root not {}".format(root.type)) -- 2.25.1
Powered by blists - more mailing lists