linux-kernel - Re: [PATCH 1/2] clk: hisilicon: Use correct return value about hisi_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 May 2020 16:02:27 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Michael Turquette <mturquette@...libre.com>,
        Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        Xuefeng Li <lixuefeng@...ngson.cn>,
        Tiezhu Yang <yangtiezhu@...ngson.cn>
Subject: Re: [PATCH 1/2] clk: hisilicon: Use correct return value about hisi_reset_init()

Quoting Tiezhu Yang (2020-05-24 20:31:55)
> The return value about hisi_reset_init() is not correct, fix it.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> ---
>  drivers/clk/hisilicon/clk-hi3519.c      | 4 ++--
>  drivers/clk/hisilicon/crg-hi3516cv300.c | 4 ++--
>  drivers/clk/hisilicon/crg-hi3798cv200.c | 4 ++--
>  drivers/clk/hisilicon/reset.c           | 4 ++--
>  4 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/clk/hisilicon/clk-hi3519.c b/drivers/clk/hisilicon/clk-hi3519.c
> index ad0c7f3..803fa66 100644
> --- a/drivers/clk/hisilicon/clk-hi3519.c
> +++ b/drivers/clk/hisilicon/clk-hi3519.c
> @@ -149,8 +149,8 @@ static int hi3519_clk_probe(struct platform_device *pdev)
>                 return -ENOMEM;
>  
>         crg->rstc = hisi_reset_init(pdev);
> -       if (!crg->rstc)
> -               return -ENOMEM;
> +       if (IS_ERR(crg->rstc))
> +               return PTR_ERR(crg->rstc);
>  
>         crg->clk_data = hi3519_clk_register(pdev);
>         if (IS_ERR(crg->clk_data)) {

The code I see is returning NULL or a valid pointer from
hisi_reset_init(). Can you add a "Fixes" tag to this patch so we can
figure out which patch changed the behavior and where this patch needs
to be backported to?