linux-kernel - Re: [PATCH v2 2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0248e0f6-7648-f08d-afa2-170ad2e724b7@web.de>
Date:   Tue, 26 May 2020 09:19:17 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     "Longpeng(Mike)" <longpeng2@...wei.com>,
        linux-crypto@...r.kernel.org,
        virtualization@...ts.linux-foundation.org
Cc:     Corentin Labbe <clabbe@...libre.com>,
        Gonglei <arei.gonglei@...wei.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2 2/2] crypto: virtio: Fix use-after-free in
 virtio_crypto_skcipher_finalize_req()

> The system'll crash when the users insmod crypto/tcrypto.ko with mode=155
> ( testing "authenc(hmac(sha1),cbc(aes))" ). It's caused by reuse the memory
> of request structure.

Wording adjustments:
* … system will crash …
* … It is caused by reusing the …


> when these memory will be used again.

when this memory …


> … Thus release specific resources before

Is there a need to improve also this information another bit?

Regards,
Markus