linux-kernel - Re: [PATCH] xen: move xen_setup_callback_vector() definition to include/xen/hvm.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd3925a5-b01f-9381-6711-4f912ac04fb5@suse.com>
Date:   Tue, 26 May 2020 10:51:47 +0200
From:   Jürgen Groß <jgross@...e.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>, x86@...nel.org
Cc:     linux-kernel@...r.kernel.org,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] xen: move xen_setup_callback_vector() definition to
 include/xen/hvm.h

On 20.05.20 18:16, Vitaly Kuznetsov wrote:
> Kbuild test robot reports the following problem on ARM:
> 
>>> drivers/xen/events/events_base.c:1664:6: warning: no previous prototype
>    for 'xen_setup_callback_vector' [-Wmissing-prototypes]
> 1664 | void xen_setup_callback_vector(void) {}
> |      ^~~~~~~~~~~~~~~~~~~~~~~~~
> The problem is that xen_setup_callback_vector is a x86 only thing, its
> definition is present in arch/x86/xen/xen-ops.h but not on ARM. In
> events_base.c we have a stub for !CONFIG_XEN_PVHVM but it is not
> declared as 'static'.
> 
> On x86 the situation is hardly better: drivers/xen/events/events_base.c
> doesn't include 'xen-ops.h' from arch/x86/xen/, it includes its namesake
> from include/xen/ so we also get the 'no previous prototype' warning.
> 
> Currently, xen_setup_callback_vector() has two call sites: one in
> drivers/xen/events_base.c and another in arch/x86/xen/suspend_hvm.c. The
> former is placed under #ifdef CONFIG_X86 and the later is only compiled
> in when CONFIG_XEN_PVHVM.
> 
> Resolve the issue by moving xen_setup_callback_vector() declaration to
> arch neutral 'include/xen/hvm.h' as the implementation lives in arch
> neutral drivers/xen/events/events_base.c.
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen