linux-kernel - Re: [PATCH] HID: sony: Fix for broken buttons on DS3 USB dongles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2005261059590.25812@cbobk.fhfr.pm>
Date:   Tue, 26 May 2020 11:00:18 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Scott Shumate <scott.shumate@...il.com>
cc:     "Colenbrander, Roderick" <Roderick.Colenbrander@...y.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: sony: Fix for broken buttons on DS3 USB dongles

On Wed, 13 May 2020, Scott Shumate wrote:

> Hi Roderick,
> 
> The official DS3 has a Report Count(19) instead of Report Count(13) in the
> exact same offset.  I have no idea what the silicon vendor for these dongles
> was thinking but it's suspicious that the official count of 19 (0x13) turned
> into 13 (0xd) in the knock-off.  It makes you wonder if the engineers confused
> the decimal/hex numbers.
> 
> As buggy as all of these third-party devices are, I'm afraid relying on the
> HID parser to get it right is only going to worse over time.  I do like your
> idea of having each device register themselves.  It would be nice to have each
> device provide a callback to decode its own report rather than handle a bunch
> of special conditions and quirks in a unified report decoding function.  The
> drawback of course is that its going to be a little more effort to maintain.

I've added Cc: stable and Fixes: tag, and applied.

Thanks,

-- 
Jiri Kosina
SUSE Labs