linux-kernel - Re: [PATCH 1/2] iommu/hyper-v: Constify hyperv_ir_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 May 2020 10:09:01 +0100
From:   Wei Liu <wei.liu@...nel.org>
To:     Rikard Falkeborn <rikard.falkeborn@...il.com>
Cc:     Joerg Roedel <joro@...tes.org>, iommu@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, linux-hyperv@...r.kernel.org
Subject: Re: [PATCH 1/2] iommu/hyper-v: Constify hyperv_ir_domain_ops

On Mon, May 25, 2020 at 11:49:57PM +0200, Rikard Falkeborn wrote:
> The struct hyperv_ir_domain_ops is not modified and can be made const to
> allow the compiler to put it in read-only memory.
> 
> Before:
>    text    data     bss     dec     hex filename
>    2916    1180    1120    5216    1460 drivers/iommu/hyperv-iommu.o
> 
> After:
>    text    data     bss     dec     hex filename
>    3044    1052    1120    5216    1460 drivers/iommu/hyperv-iommu.o
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com>

Acked-by: Wei Liu <wei.liu@...nel.org>

> ---
>  drivers/iommu/hyperv-iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/hyperv-iommu.c b/drivers/iommu/hyperv-iommu.c
> index a386b83e0e34..3c0c67a99c7b 100644
> --- a/drivers/iommu/hyperv-iommu.c
> +++ b/drivers/iommu/hyperv-iommu.c
> @@ -131,7 +131,7 @@ static int hyperv_irq_remapping_activate(struct irq_domain *domain,
>  	return 0;
>  }
>  
> -static struct irq_domain_ops hyperv_ir_domain_ops = {
> +static const struct irq_domain_ops hyperv_ir_domain_ops = {
>  	.alloc = hyperv_irq_remapping_alloc,
>  	.free = hyperv_irq_remapping_free,
>  	.activate = hyperv_irq_remapping_activate,
> -- 
> 2.26.2
>