linux-kernel - Re: [PATCH] scsi: ufs-qcom: Fix scheduling while atomic issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 May 2020 11:41:52 +0200
From:   Bean Huo <huobean@...il.com>
To:     Avri Altman <Avri.Altman@....com>,
        Jeffrey Hugo <jeffrey.l.hugo@...il.com>,
        "agross@...nel.org" <agross@...nel.org>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "subhashj@...eaurora.org" <subhashj@...eaurora.org>,
        "venkatg@...eaurora.org" <venkatg@...eaurora.org>
Cc:     "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: ufs-qcom: Fix scheduling while atomic issue

On Tue, 2020-05-26 at 06:25 +0000, Avri Altman wrote:
>  
> > ufs_qcom_dump_dbg_regs() uses usleep_range, a sleeping function,
> > but can
> > be called from atomic context in the following flow:
> > 
> > ufshcd_intr -> ufshcd_sl_intr -> ufshcd_check_errors ->
> > ufshcd_print_host_regs -> ufshcd_vops_dbg_register_dump ->
> > ufs_qcom_dump_dbg_regs
> > 
> > This causes a boot crash on the Lenovo Miix 630 when the interrupt
> > is
> > handled on the idle thread.
> > 
> > Fix the issue by switching to udelay().
> > 
> > Fixes: 9c46b8676271 ("scsi: ufs-qcom: dump additional testbus
> > registers")
> > Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@...il.com>
> 
> Reviewed-by: Avri Altman <avri.altman@....com>
Reviewed-by: Bean Huo <beanhuo@...ron.com>