linux-kernel - Re: Re: [PATCH] scsi: ufs: Fix runtime PM imbalance on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20dbb267.d17cd.172507864cf.Coremail.dinghao.liu@zju.edu.cn>
Date:   Tue, 26 May 2020 18:12:46 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Vignesh Raghavendra" <vigneshr@...com>
Cc:     kjlu@....edu, "Alim Akhtar" <alim.akhtar@...sung.com>,
        "Avri Altman" <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] scsi: ufs: Fix runtime PM imbalance on error

> Hi,
> 
> On 22/05/20 10:23 am, Dinghao Liu wrote:
> > When devm_clk_get() returns an error code, a pairing
> > runtime PM usage counter decrement is needed to keep
> > the counter balanced.
> > 
> > Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> > ---
> 
> Thanks for the patch! But this fix is incomplete, I have posted 
> a more comprehensive fix at [1].. Please take a look!


You are right, we should call pm_runtime_disable() on error, too.
Thank your for your reminder!

Regards,
Dinghao