linux-kernel - Re: [PATCH] ACPI/IORT: Remove the unused __get_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200526130752.GA23951@e121166-lin.cambridge.arm.com>
Date:   Tue, 26 May 2020 14:07:52 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Zenghui Yu <yuzenghui@...wei.com>, will@...nel.org
Cc:     guohanjun@...wei.com, sudeep.holla@....com, rjw@...ysocki.net,
        lenb@...nel.org, linux-acpi@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        wanghaibin.wang@...wei.com
Subject: Re: [PATCH] ACPI/IORT: Remove the unused __get_pci_rid()

On Sat, May 09, 2020 at 05:34:30PM +0800, Zenghui Yu wrote:
> Since commit bc8648d49a95 ("ACPI/IORT: Handle PCI aliases properly for
> IOMMUs"), __get_pci_rid() has become actually unused and can be removed.
> 
> Signed-off-by: Zenghui Yu <yuzenghui@...wei.com>
> ---
>  drivers/acpi/arm64/iort.c | 9 ---------
>  1 file changed, 9 deletions(-)

Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@....com>

If we miss v5.8 (which I think it is likely, even though this patch is
just removing dead code so it is safe at this stage) I will resend it
for v5.9 - not a problem.

Lorenzo

> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index 7d04424189df..ec94dbb60c7a 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -789,15 +789,6 @@ void acpi_configure_pmsi_domain(struct device *dev)
>  		dev_set_msi_domain(dev, msi_domain);
>  }
>  
> -static int __maybe_unused __get_pci_rid(struct pci_dev *pdev, u16 alias,
> -					void *data)
> -{
> -	u32 *rid = data;
> -
> -	*rid = alias;
> -	return 0;
> -}
> -
>  #ifdef CONFIG_IOMMU_API
>  static struct acpi_iort_node *iort_get_msi_resv_iommu(struct device *dev)
>  {
> -- 
> 2.19.1
>