linux-kernel - Re: [PATCH] PCI: qcom: Improve exception handling in qcom_pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c0e71850-a67b-2aac-7ddc-186f3850c087@web.de>
Date:   Tue, 26 May 2020 16:30:34 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Qiushi Wu <wu000273@....edu>, linux-arm-msm@...r.kernel.org,
        linux-pci@...r.kernel.org
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>, Kangjie Lu <kjlu@....edu>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Rob Herring <robh@...nel.org>,
        Stanimir Varbanov <svarbanov@...sol.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: qcom: Improve exception handling in
 qcom_pcie_probe()

Please avoid a typo in the patch subject (by a possible alternative?).


> In function qcom_pcie_probe(), there are several error-handling problem.

Wording adjustments:
This function contained improvable implementation details according to
exception handling.


> because refcount will be increased even pm_runtime_get_sync() returns
> an error.

because the reference count will be increased despite of the failure.
Thus add the missed function call.


> 2. pm_runtime_disable() are called twice, …
…
Thus remove redundant function calls.

Regards,
Markus