linux-kernel - Re: [PATCHv2 1/2] spi: dw: add reset control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 May 2020 18:21:29 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Dinh Nguyen <dinguyen@...nel.org>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        broonie@...nel.org, robh+dt@...nel.org, linux-spi@...r.kernel.org,
        Sergey.Semin@...kalelectronics.ru, fancer.lancer@...il.com,
        lars.povlsen@...rochip.com, Liang Jin J <liang.j.jin@...csson.com>
Subject: Re: [PATCHv2 1/2] spi: dw: add reset control

On Tue, May 26, 2020 at 10:12:17AM -0500, Dinh Nguyen wrote:
> Add mechanism to get the reset control and deassert it in order to bring
> the IP out of reset.

...

>  	struct clk     *clk;
>  	struct clk     *pclk;
>  	void           *priv;
> +	struct reset_control	*rstc;

I think either you make it one space or you align all the rest members
accordingly. I would rather go with former.

...

> +	/* find an optional reset controller */
> +	dwsmmio->rstc = devm_reset_control_get_optional_exclusive(&pdev->dev, "spi");
> +	if (IS_ERR(dwsmmio->rstc)) {

> +		if (PTR_ERR(dwsmmio->rstc) == -EPROBE_DEFER)
> +			return PTR_ERR(dwsmmio->rstc);

If it's other type of errors when reset control, we ignore them...

Why?!

> +	}

-- 
With Best Regards,
Andy Shevchenko