linux-kernel - Re: [PATCH] MIPS: BCM63xx: fix 6328 boot selection bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <862863b2-d73e-0c48-6503-c912c60c1b94@gmail.com>
Date:   Tue, 26 May 2020 09:15:54 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Álvaro Fernández Rojas <noltari@...il.com>,
        tsbogend@...ha.franken.de, jonas.gorski@...il.com,
        bcm-kernel-feedback-list@...adcom.com, linux-mips@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: BCM63xx: fix 6328 boot selection bit



On 5/26/2020 4:03 AM, Álvaro Fernández Rojas wrote:
> MISC_STRAP_BUS_BOOT_SEL_SHIFT is 18 according to Broadcom's GPL source code.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>

This is correct:

Acked-by: Florian Fainelli <f.fainelli@...il.com>

Fixes: e5766aea5b9b ("MIPS: BCM63XX: Add basic BCM6328 support")

> ---
>  arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h
> index bc3444cd4ef2..9ceb5e72889f 100644
> --- a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h
> +++ b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h
> @@ -1367,8 +1367,8 @@
>  #define MISC_STRAPBUS_6328_REG		0x240
>  #define STRAPBUS_6328_FCVO_SHIFT	7
>  #define STRAPBUS_6328_FCVO_MASK		(0x1f << STRAPBUS_6328_FCVO_SHIFT)
> -#define STRAPBUS_6328_BOOT_SEL_SERIAL	(1 << 28)
> -#define STRAPBUS_6328_BOOT_SEL_NAND	(0 << 28)
> +#define STRAPBUS_6328_BOOT_SEL_SERIAL	(1 << 18)
> +#define STRAPBUS_6328_BOOT_SEL_NAND	(0 << 18)
>  
>  /*************************************************************************
>   * _REG relative to RSET_PCIE
> 

-- 
Florian