linux-kernel - Re: linux-next: Tree for May 26 (hwmon/amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 May 2020 10:17:16 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Guenter Roeck <linux@...ck-us.net>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Naveen Krishna Chatradhi <nchatrad@....com>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>
Subject: Re: linux-next: Tree for May 26 (hwmon/amd_energy.c)

On 5/26/20 10:14 AM, Guenter Roeck wrote:
> On 5/26/20 9:24 AM, Randy Dunlap wrote:
>> On 5/26/20 3:39 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> News: there will be no linux-next release tomorrow.
>>>
>>> Changes since 20200525:
>>>
>>
>> Hi,
>>
>> All of my drivers/hwmon/amd_energy.c builds are failing (on i386 or x86_64).
>>
> I don't see that, neither in my hwmon-next branch (on top of v5.7-rc6)
> nor with next-20200526.
> 
> Ah yes, you must have NUMA and NEED_MULTIPLE_NODES disabled.
> With that (allnoconfig+HWMON+SENSORS_AMD_ENERGY), I see the error as well.
> The problem is:
> 
> 	#define cpumask_of_node(node)       ((void)node, cpu_online_mask)
> 
> The caller passes node as "channel - data->nr_cpus", which I would argue
> is perfectly valid. This is converted to
> 
> 	#define cpumask_of_node(node)       ((void)channel - data->nr_cpus, cpu_online_mask)
> 
> which doesn't look that good and results in the error. The problem
> is the missing ( ) around node, not the amd_energy driver.
> 
> Do you want to submit a patch, or do you want me to do it ?

You go ahead, please.

thanks.
-- 
~Randy