linux-kernel - Re: [PATCH] net: dsa: b53: remove redundant premature assignment to new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200527.112922.1235278258146783650.davem@davemloft.net>
Date:   Wed, 27 May 2020 11:29:22 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     f.fainelli@...il.com, andrew@...n.ch, vivien.didelot@...il.com,
        kuba@...nel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: b53: remove redundant premature assignment
 to new_pvid

From: Colin King <colin.king@...onical.com>
Date: Wed, 27 May 2020 13:01:29 +0100

> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable new_pvid is being assigned with a value that is never read,
> the following if statement updates new_pvid with a new value in both
> of the if paths. The assignment is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied to net-next, thanks.