linux-kernel - Re: [PATCH] iio: mma8452: Add missed iio_device_unregister() call in mma8452

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <818d7c1b-ab4f-f254-3ada-99fed5108f3f@web.de>
Date:   Wed, 27 May 2020 21:55:25 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Chuhong Yuan <hslester96@...il.com>, linux-iio@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Hartmut Knaack <knaack.h@....de>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>
Subject: Re: [PATCH] iio: mma8452: Add missed iio_device_unregister() call in
 mma8452_probe()

> mma8452_probe() calls iio_device_register() but misses to call
> iio_device_unregister() when probe fails.
> Add the missed call in error handler to fix it.

How do you think about a wording variant like the following?

   Change description:
   The function “iio_device_register” was called here.
   But the function “iio_device_unregister” was not called after
   a call of the function “mma8452_set_freefall_mode” failed.
   Thus add the missed function call for one error case.

Would you like to add the tag “Fixes”?

Regards,
Markus