linux-kernel - Re: [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200527204334.GA15485@kevin>
Date:   Wed, 27 May 2020 16:43:34 -0400
From:   Alyssa Rosenzweig <alyssa.rosenzweig@...labora.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Rob Herring <robh@...nel.org>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        Steven Price <steven.price@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred
 probe

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@...labora.com>

On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote:
> There is no point to print deferred probe (and its failures to get
> resources) as an error.  Also there is no need to print regulator errors
> twice.
> 
> In case of multiple probe tries this would pollute the dmesg.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> Reviewed-by: Steven Price <steven.price@....com>
> 
> ---
> 
> Changes since v2:
> 1. Rebase
> 2. Add Steven's review
> 
> Changes since v1:
> 1. Remove second error message from calling panfrost_regulator_init()
> ---
>  drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
> index 8136babd3ba9..b172087eee6a 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_device.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_device.c
> @@ -101,7 +101,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
>  				      pfdev->comp->num_supplies,
>  				      pfdev->regulators);
>  	if (ret < 0) {
> -		dev_err(pfdev->dev, "failed to get regulators: %d\n", ret);
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(pfdev->dev, "failed to get regulators: %d\n",
> +				ret);
>  		return ret;
>  	}
>  
> @@ -213,10 +215,8 @@ int panfrost_device_init(struct panfrost_device *pfdev)
>  	}
>  
>  	err = panfrost_regulator_init(pfdev);
> -	if (err) {
> -		dev_err(pfdev->dev, "regulator init failed %d\n", err);
> +	if (err)
>  		goto err_out0;
> -	}
>  
>  	err = panfrost_reset_init(pfdev);
>  	if (err) {
> -- 
> 2.17.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)