linux-kernel - Re: [PATCH resend 3/3] mm: fix LRU balancing effect of new transparent huge pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200527134650.18b3fb3f0be85bb73037da20@linux-foundation.org>
Date:   Wed, 27 May 2020 13:46:50 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Johannes Weiner <hannes@...xchg.org>
Cc:     Shakeel Butt <shakeelb@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Roman Gushchin <guro@...com>, Michal Hocko <mhocko@...nel.org>,
        Minchan Kim <minchan@...nel.org>,
        Rik van Riel <riel@...riel.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH resend 3/3] mm: fix LRU balancing effect of new
 transparent huge pages

On Wed, 27 May 2020 15:41:48 -0400 Johannes Weiner <hannes@...xchg.org> wrote:

> On Wed, May 27, 2020 at 11:29:58AM -0700, Shakeel Butt wrote:
> > From: Johannes Weiner <hannes@...xchg.org>
> > 
> > Currently, THP are counted as single pages until they are split right
> > before being swapped out. However, at that point the VM is already in
> > the middle of reclaim, and adjusting the LRU balance then is useless.
> > 
> > Always account THP by the number of basepages, and remove the fixup
> > from the splitting path.
> > 
> > Signed-off-by: Johannes Weiner <hannes@...xchg.org>
> > Signed-off-by: Shakeel Butt <shakeelb@...gle.com>
> 
> This is now already in mm as part of the "mm: balance LRU lists based
> on relative thrashing" series that I sent out last week and where it
> was originally from.

Yup.  I hope [1/3] and [2/3] weren't urgent?  Due to a horrid merge
mismatchmishmashmess I've staged them behind lots of other things,
notably

thp/khugepaged improvements and CoW semantics
http://lkml.kernel.org/r/20200416160026.16538-1-kirill.shutemov@linux.intel.com

and mm: memcontrol: charge swapin pages on instantiation
http://lkml.kernel.org/r/20200508183105.225460-1-hannes@cmpxchg.org

and mm: balance LRU lists based on relative thrashing
http://lkml.kernel.org/r/20200520232525.798933-1-hannes@cmpxchg.org