linux-kernel - [PATCH] lightnvm: pblk: Fix reference count leak in pblk_sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200527210628.9477-1-wu000273@umn.edu>
Date:   Wed, 27 May 2020 16:06:28 -0500
From:   wu000273@....edu
To:     kjlu@....edu
Cc:     wu000273@....edu, Matias Bjorling <mb@...htnvm.io>,
        Matias Bjørling <matias@...xlabs.com>,
        Jens Axboe <axboe@...com>,
        Javier González <jg@...htnvm.io>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] lightnvm: pblk: Fix reference count leak in pblk_sysfs_init.

From: Qiushi Wu <wu000273@....edu>

kobject_init_and_add() takes reference even when it fails.
Thus, when kobject_init_and_add() returns an error,
kobject_put() must be called to properly clean up the kobject.

Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target")
Signed-off-by: Qiushi Wu <wu000273@....edu>
---
 drivers/lightnvm/pblk-sysfs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/lightnvm/pblk-sysfs.c b/drivers/lightnvm/pblk-sysfs.c
index 6387302b03f2..90f1433b19a2 100644
--- a/drivers/lightnvm/pblk-sysfs.c
+++ b/drivers/lightnvm/pblk-sysfs.c
@@ -711,6 +711,7 @@ int pblk_sysfs_init(struct gendisk *tdisk)
 					"%s", "pblk");
 	if (ret) {
 		pblk_err(pblk, "could not register\n");
+		kobject_put(&pblk->kobj);
 		return ret;
 	}
 
-- 
2.17.1