linux-kernel - Re: [PATCH 1/2] xen-pciback: Use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <612fee00-4e7c-9b90-511d-4efb7676cbed@oracle.com>
Date:   Wed, 27 May 2020 15:34:26 -0700 (PDT)
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Bjorn Helgaas <helgaas@...nel.org>, Juergen Gross <jgross@...e.com>
Cc:     Stefano Stabellini <sstabellini@...nel.org>,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH 1/2] xen-pciback: Use dev_printk() when possible

On 5/27/20 1:43 PM, Bjorn Helgaas wrote:
> @@ -155,8 +157,8 @@ int xen_pcibk_config_read(struct pci_dev *dev, int offset, int size,
>  	u32 value = 0, tmp_val;
>  
>  	if (unlikely(verbose_request))
> -		printk(KERN_DEBUG DRV_NAME ": %s: read %d bytes at 0x%x\n",
> -		       pci_name(dev), size, offset);
> +		dev_printk(KERN_DEBUG, &dev->dev, "read %d bytes at 0x%x\n",
> +			   size, offset);


Maybe then dev_dbg() ?


-boris