linux-kernel - Re: [PATCH 2/6] iio: dac: ad5380: Constify struct iio_chan_spec_ext

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfbaa1863b7bc3f69a184bb4d7b7ee7805f06e88.camel@analog.com>
Date:   Wed, 27 May 2020 04:22:30 +0000
From:   "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
To:     "rikard.falkeborn@...il.com" <rikard.falkeborn@...il.com>,
        "jic23@...nel.org" <jic23@...nel.org>
CC:     "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        "knaack.h@....de" <knaack.h@....de>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "pmeerw@...erw.net" <pmeerw@...erw.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/6] iio: dac: ad5380: Constify struct
 iio_chan_spec_ext_info

On Tue, 2020-05-26 at 23:02 +0200, Rikard Falkeborn wrote:
> [External]
> 
> ad5380_ext_info is not modified and can be made const to allow the
> compiler to put it in read-only memory.
> 
> Before:
>    text    data     bss     dec     hex filename
>   12060    3280     192   15532    3cac drivers/iio/dac/ad5380.o
> 
> After:
>    text    data     bss     dec     hex filename
>   12252    3088     192   15532    3cac drivers/iio/dac/ad5380.o
> 

Acked-by: Alexandru Ardelean <alexandru.ardelean@...log.com>

> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com>
> ---
>  drivers/iio/dac/ad5380.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c
> index b37e5675f716..04c74cc1a4ec 100644
> --- a/drivers/iio/dac/ad5380.c
> +++ b/drivers/iio/dac/ad5380.c
> @@ -240,7 +240,7 @@ static const struct iio_info ad5380_info = {
>  	.write_raw = ad5380_write_raw,
>  };
>  
> -static struct iio_chan_spec_ext_info ad5380_ext_info[] = {
> +static const struct iio_chan_spec_ext_info ad5380_ext_info[] = {
>  	{
>  		.name = "powerdown",
>  		.read = ad5380_read_dac_powerdown,