linux-kernel - Re: Re: [PATCH] ASoC: Intel: sst: Fix runtime PM imbalance in sst_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 May 2020 09:07:40 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Pierre-Louis Bossart" <pierre-louis.bossart@...ux.intel.com>
Cc:     kjlu@....edu, "Cezary Rojewski" <cezary.rojewski@...el.com>,
        "Liam Girdwood" <liam.r.girdwood@...ux.intel.com>,
        "Jie Yang" <yang.jie@...ux.intel.com>,
        "Mark Brown" <broonie@...nel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "Takashi Iwai" <tiwai@...e.com>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Allison Randal" <allison@...utok.net>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Alexios Zavras" <alexios.zavras@...el.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] ASoC: Intel: sst: Fix runtime PM imbalance in
 sst_power_control

> 
> this change doesn't seem quite right, if you look the code below there 
> is no PM imbalance, is there?
> 
> int sst_pm_runtime_put(struct intel_sst_drv *sst_drv)
> {
> 	int ret;
> 
> 	pm_runtime_mark_last_busy(sst_drv->dev);
> 	ret = pm_runtime_put_autosuspend(sst_drv->dev);
> 	if (ret < 0)
> 		return ret;
> 	return 0;
> }

You are right. Thank you for your correction!

Regards,
Dinghao