linux-kernel - Re: [PATCH v6 3/4] mm/memory.c: Add memory read privilege on page fault handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200527071046.GA8600@alpha.franken.de>
Date:   Wed, 27 May 2020 09:10:46 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     maobibo <maobibo@...ngson.cn>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Huacai Chen <chenhc@...ote.com>,
        Paul Burton <paulburton@...nel.org>,
        Dmitry Korotin <dkorotin@...ecomp.com>,
        Philippe Mathieu-Daudé <f4bug@...at.org>,
        Stafford Horne <shorne@...il.com>,
        Steven Price <steven.price@....com>,
        Anshuman Khandual <anshuman.khandual@....com>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        "Maciej W. Rozycki" <macro@....com>, linux-mm@...ck.org,
        David Hildenbrand <david@...hat.com>
Subject: Re: [PATCH v6 3/4] mm/memory.c: Add memory read privilege on page
 fault handling

On Wed, May 27, 2020 at 09:05:41AM +0800, maobibo wrote:
> 
> 
> On 05/26/2020 05:44 AM, Andrew Morton wrote:
> > On Mon, 25 May 2020 10:52:39 +0800 Bibo Mao <maobibo@...ngson.cn> wrote:
> > 
> >> Here add pte_sw_mkyoung function to make page readable on MIPS
> >> platform during page fault handling. This patch improves page
> >> fault latency about 10% on my MIPS machine with lmbench
> >> lat_pagefault case.
> >>
> >> It is noop function on other arches, there is no negative
> >> influence on those architectures.
> > 
> > Acked-by: Andrew Morton <akpm@...ux-foundation.org>
> > 
> > Should I take these, or would the mips tree be preferred?  I'm OK
> > either way, but probably the MIPS tree would be better?
> Thanks for reviewing again and again.
> This patch is based on mips-next, maybe MIPS tree will be better.

I'll take your next version then.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]