linux-kernel - Re: [PATCH 4.4 26/65] sched/fair, cpumask: Export for_each_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200527080944.GB119903@kroah.com>
Date:   Wed, 27 May 2020 10:09:44 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     nobuhiro1.iwamatsu@...hiba.co.jp
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        peterz@...radead.org, lvenanci@...hat.com,
        torvalds@...ux-foundation.org, efault@....de, riel@...hat.com,
        tglx@...utronix.de, lwang@...hat.com, mingo@...nel.org,
        daniel.m.jordan@...cle.com, sashal@...nel.org
Subject: Re: [PATCH 4.4 26/65] sched/fair, cpumask: Export for_each_cpu_wrap()

On Wed, May 27, 2020 at 07:50:56AM +0000, nobuhiro1.iwamatsu@...hiba.co.jp wrote:
> Hi,
> 
> > -----Original Message-----
> > From: stable-owner@...r.kernel.org [mailto:stable-owner@...r.kernel.org] On Behalf Of Greg Kroah-Hartman
> > Sent: Wednesday, May 27, 2020 3:53 AM
> > To: linux-kernel@...r.kernel.org
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; stable@...r.kernel.org; Peter Zijlstra (Intel)
> > <peterz@...radead.org>; Lauro Ramos Venancio <lvenanci@...hat.com>; Linus Torvalds <torvalds@...ux-foundation.org>;
> > Mike Galbraith <efault@....de>; Rik van Riel <riel@...hat.com>; Thomas Gleixner <tglx@...utronix.de>;
> > lwang@...hat.com; Ingo Molnar <mingo@...nel.org>; Daniel Jordan <daniel.m.jordan@...cle.com>; Sasha Levin
> > <sashal@...nel.org>
> > Subject: [PATCH 4.4 26/65] sched/fair, cpumask: Export for_each_cpu_wrap()	
> > 
> > From: Peter Zijlstra <peterz@...radead.org>
> > 
> > [ Upstream commit c743f0a5c50f2fcbc628526279cfa24f3dabe182 ]
> > 
> > More users for for_each_cpu_wrap() have appeared. Promote the construct
> > to generic cpumask interface.
> > 
> > The implementation is slightly modified to reduce arguments.
> > 
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> > Cc: Lauro Ramos Venancio <lvenanci@...hat.com>
> > Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> > Cc: Mike Galbraith <efault@....de>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Cc: Rik van Riel <riel@...hat.com>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: lwang@...hat.com
> > Link: http://lkml.kernel.org/r/20170414122005.o35me2h5nowqkxbv@hirez.programming.kicks-ass.net
> > Signed-off-by: Ingo Molnar <mingo@...nel.org>
> > [dj: include only what's added to the cpumask interface, 4.4 doesn't
> >      have them in the scheduler]
> > Signed-off-by: Daniel Jordan <daniel.m.jordan@...cle.com>
> > Signed-off-by: Sasha Levin <sashal@...nel.org>
> > ---
> >  include/linux/cpumask.h | 17 +++++++++++++++++
> >  lib/cpumask.c           | 32 ++++++++++++++++++++++++++++++++
> >  2 files changed, 49 insertions(+)
> 
> This commit also needs the following commits:
> 
> commit d207af2eab3f8668b95ad02b21930481c42806fd
> Author: Michael Kelley <mhkelley@...look.com>
> Date:   Wed Feb 14 02:54:03 2018 +0000
> 
>     cpumask: Make for_each_cpu_wrap() available on UP as well
>     
>     for_each_cpu_wrap() was originally added in the #else half of a
>     large "#if NR_CPUS == 1" statement, but was omitted in the #if
>     half.  This patch adds the missing #if half to prevent compile
>     errors when NR_CPUS is 1.
>     
>     Reported-by: kbuild test robot <fengguang.wu@...el.com>
>     Signed-off-by: Michael Kelley <mhkelley@...look.com>
>     Cc: Linus Torvalds <torvalds@...ux-foundation.org>
>     Cc: Peter Zijlstra <peterz@...radead.org>
>     Cc: Thomas Gleixner <tglx@...utronix.de>
>     Cc: kys@...rosoft.com
>     Cc: martin.petersen@...cle.com
>     Cc: mikelley@...rosoft.com
>     Fixes: c743f0a5c50f ("sched/fair, cpumask: Export for_each_cpu_wrap()")
>     Link: http://lkml.kernel.org/r/SN6PR1901MB2045F087F59450507D4FCC17CBF50@SN6PR1901MB2045.namprd19.prod.outlook.com
>     Signed-off-by: Ingo Molnar <mingo@...nel.org>
> 
> Please apply this commit.

Good catch, now queued up, thanks.

greg k-h