linux-kernel - Re: [v1,1/1 1/2] Check the timeout module parameter is in the min-max range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f482f42-0977-db1d-704a-b6f83ad715ef@roeck-us.net>
Date:   Tue, 26 May 2020 18:42:56 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     yuechao.zhao@...antech.com.cn, 345351830@...com
Cc:     amy.shih@...antech.com.tw, oakley.ding@...antech.com.tw,
        jia.sui@...antech.com.cn, Jean Delvare <jdelvare@...e.com>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [v1,1/1 1/2] Check the timeout module parameter is in the min-max
 range

On 5/26/20 6:18 PM, yuechao.zhao@...antech.com.cn wrote:
> From: Yuechao Zhao <yuechao.zhao@...antech.com.cn>
> 
> Check the return value of 'watchdog_init_timeout()' for checking the
> timeout module parameter is in the min-max range.
> 
> Signed-off-by: Yuechao Zhao <yuechao.zhao@...antech.com.cn>

Please fix the subject. It should start with "hwmon: (nct7904)"

> ---
>  drivers/hwmon/nct7904.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
> index 18c95be..d069d59 100644
> --- a/drivers/hwmon/nct7904.c
> +++ b/drivers/hwmon/nct7904.c
> @@ -1152,7 +1152,10 @@ static int nct7904_probe(struct i2c_client *client,
>  	data->wdt.max_timeout = MAX_TIMEOUT;
>  	data->wdt.parent = &client->dev;
>  
> -	watchdog_init_timeout(&data->wdt, timeout * 60, &client->dev);
> +	ret = watchdog_init_timeout(&data->wdt, timeout * 60, &client->dev);
> +	if (ret < 0)
> +		return ret;
> +

Why ? The idea of returning an error from watchdog_init_timeout
is to give the driver a chance to select a default, not to refuse
loading the driver.

>  	watchdog_set_nowayout(&data->wdt, nowayout);
>  	watchdog_set_drvdata(&data->wdt, data);
>  
>