linux-kernel - Re: [PATCH] perf jvmti: remove redundant jitdump line table entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <FAA0E3A0-505F-4EEE-9509-A174FACB6AC6@gmail.com>
Date:   Wed, 27 May 2020 09:43:40 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Nick Gasson <nick.gasson@....com>, Jiri Olsa <jolsa@...hat.com>
CC:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ian Rogers <irogers@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Stephane Eranian <eranian@...gle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf jvmti: remove redundant jitdump line table entries



On May 27, 2020 2:29:05 AM GMT-03:00, Nick Gasson <nick.gasson@....com> wrote:
>On 05/26/20 19:55 PM, Jiri Olsa wrote:
>> On Fri, May 22, 2020 at 02:53:30PM +0800, Nick Gasson wrote:
>>> For each PC/BCI pair in the JVMTI compiler inlining record table,
>the
>>> jitdump plugin emits debug line table entries for every source line
>in
>>> the method preceding that BCI. Instead only emit one source line per
>>> PC/BCI pair. Reported by Ian Rogers. This reduces the .dump size for
>>> SPECjbb from ~230MB to ~40MB.
>>> 
>>> Also fix an error in the DWARF line table state machine where
>addresses
>>> are incorrectly offset by -0x40 (GEN_ELF_TEXT_OFFSET). This can be
>seen
>>> with `objdump -S` on the ELF files after perf inject.
>>
>> hi,
>> I can't apply this on latest Arnaldo's perf/core:
>>
>> patching file jvmti/libjvmti.c
>> Hunk #1 FAILED at 32.
>> Hunk #2 succeeded at 67 (offset -4 lines).
>> Hunk #3 FAILED at 85.
>> Hunk #4 succeeded at 114 (offset -7 lines).
>>
>
>Sorry I based this on my earlier patch series below but I didn't
>realise
>that wasn't merged to perf/core yet. Could those patches be applied
>first? I believe Ian added a Reviewed-by for all three.
>
>https://lore.kernel.org/lkml/20200427061520.24905-3-nick.gasson@arm.com/T/

I'll check, thanks
- Arnaldo

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.