linux-kernel - Re: [PATCH V2 3/3] perf/x86/intel/uncore: Validate MMIO address before accessing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6746309b-c761-e338-c7d6-85ab6edb9052@linux.intel.com>
Date:   Thu, 28 May 2020 10:08:29 -0400
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     David Laight <David.Laight@...lab.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 3/3] perf/x86/intel/uncore: Validate MMIO address
 before accessing



On 5/28/2020 10:02 AM, Andi Kleen wrote:
>>>> +
>>>> +	pr_warn_once("perf uncore: Access invalid address of %s.\n",
>>>> +		     box->pmu->type->name);
>>>
>>> Pretty hard to debug without the invalid offset.
>>>
>>
>> I will dump the box->io_addr and offset for debugging.
> 
> Please don't overengineer.
> 

OK. Will only dump the invalid offset.

Thanks,
Kan