linux-kernel - Re: [PATCH] Bluetooth: btmtkuart: Improve exception handling in btmtuart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <dd458e1d-26cf-2cc6-4fdb-fb464f9c3ac6@web.de>
Date:   Thu, 28 May 2020 19:09:17 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Chuhong Yuan <hslester96@...il.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-bluetooth@...r.kernel.org, linux-mediatek@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Johan Hedberg <johan.hedberg@...il.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Sean Wang <sean.wang@...iatek.com>
Subject: Re: [PATCH] Bluetooth: btmtkuart: Improve exception handling in
 btmtuart_probe()

> btmtuart_probe() misses several function calls in its error paths,
> including hci_free_dev() and clk_disable_unprepare().
> Refactor the code and call correct undo functions to fix the error
> paths.

How do you think about a wording variant like the following?

   Change description:
   Calls of the functions “clk_disable_unprepare” and “hci_free_dev”
   were missing for the exception handling.
   Thus add the missed function calls together with corresponding
   jump targets.


Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus