linux-kernel - Re: [PATCH net] net: mvpp2: Enable autoneg bypass for 1000BaseX/2500BaseX ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 May 2020 20:43:12 +0200
From:   Thomas Bogendoerfer <tbogendoerfer@...e.de>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: mvpp2: Enable autoneg bypass for
 1000BaseX/2500BaseX ports

On Thu, 28 May 2020 15:48:05 +0100
Russell King - ARM Linux admin <linux@...linux.org.uk> wrote:

> On Thu, May 28, 2020 at 04:33:35PM +0200, Thomas Bogendoerfer wrote:
> > below is the dts part for the two network interfaces. The switch to
> > the outside has two ports, which correlate to the two internal ports.
> > And the switch propagates the link state of the external ports to
> > the internal ports.
> 
> Okay, so this DTS hasn't been reviewed...

that's from our partner, I'm just using it. Stripping it down isn't
the point for my now.

> This isn't correct - you are requesting that in-band status is used
> (i.o.w. the in-band control word, see commit 4cba5c210365), but your
> bug report wants to enable AN bypass because there is no in-band
> control word.  This seems to be rather contradictory.
> 
> May I suggest you use a fixed-link here, which will not have any

afaik fixed-link will always be up, and we want to have the link state
from the switch external ports.

> inband status, as there is no in-band control word being sent by
> the switch?  That is also the conventional way of handling switch
> links.

again, we want to propagte the external link state inside to all
the internal nodes. So this will not work anymore with fixed-link.

Thomas.

-- 
SUSE Software Solutions Germany GmbH
HRB 36809 (AG Nürnberg)
Geschäftsführer: Felix Imendörffer