linux-kernel - Re: clean up kernel_{read,write} & friends v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPM=9twsu9bUpaCUVfb2sgHQsvSJiE5qRyiigLBJe5+3WMq8aQ@mail.gmail.com>
Date:   Fri, 29 May 2020 06:29:42 +1000
From:   Dave Airlie <airlied@...il.com>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Joe Perches <joe@...ches.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Christoph Hellwig <hch@....de>, Ian Kent <raven@...maw.net>,
        David Howells <dhowells@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        LSM List <linux-security-module@...r.kernel.org>,
        NetFilter <netfilter-devel@...r.kernel.org>
Subject: Re: clean up kernel_{read,write} & friends v2

On Fri, 29 May 2020 at 05:35, Al Viro <viro@...iv.linux.org.uk> wrote:
>
> On Thu, May 28, 2020 at 12:22:08PM -0700, Joe Perches wrote:
>
> > Hard limits at 80 really don't work well, especially with
> > some of the 25+ character length identifiers used today.
>
> IMO any such identifier is a good reason for a warning.
>
> The litmus test is actually very simple: how unpleasant would it be
> to mention the identifiers while discussing the code over the phone?

That doesn't make sense though,

if you write the full english words out for something it'll be long
but easier to say over the phone,
if you use shortened kernel abbreviations it will be short but you'd
have to read out every letter.

To take an example:
this would read pretty well on the phone, maybe params could be parameters
amdgpu_atombios_get_leakage_vddc_based_on_leakage_params

vddc would be a stumbler.

try saying O_CREAT over the phone to someone not steeped in UNIX folklore.

Dave.