linux-kernel - Re: [PATCH v2 net-next 2/4] vmxnet3: add support to get/set rx flow hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 May 2020 21:09:27 +0000
From:   Ronak Doshi <doshir@...are.com>
To:     Michal Kubecek <mkubecek@...e.cz>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Pv-drivers <Pv-drivers@...are.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 2/4] vmxnet3: add support to get/set rx flow
 hash


On 5/28/20, 1:15 PM, "Michal Kubecek" <mkubecek@...e.cz> wrote:
>    This means that for both TCP and UDP, you have cases where get handler
>    will return value which will cause an error if it's fed back to set
>    handler. And for UDP, accepted values for set are L3 and L3 | L4 but get
>    handler returns 0 or L3 | L4.
>    
>    So UDP part is wrong and if TCP always hashes by all four fields, it
>    would be cleaner to return that information unconditionally, like you do
>    e.g. for ESPv6 (with a different value).
>    
>    Michal

Okay, yes for UDP I should return L3 instead of 0 when rss_fields does not
support UDP RSS. I made these changes to avoid fallthrough, but missed this
part. Also, will remove the check for TCP and pass it unconditionally.

Thanks