linux-kernel - Re: [PATCH v3 net-next 3/4] vmxnet3: add geneve and vxlan tunnel offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200528.144358.1981651162176500485.davem@davemloft.net>
Date:   Thu, 28 May 2020 14:43:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     doshir@...are.com
Cc:     netdev@...r.kernel.org, pv-drivers@...are.com, kuba@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 net-next 3/4] vmxnet3: add geneve and vxlan tunnel
 offload support

From: Ronak Doshi <doshir@...are.com>
Date: Thu, 28 May 2020 14:32:02 -0700

> +			BUG_ON(!(gdesc->rcd.tcp || gdesc->rcd.udp) &&
> +			       !(le32_to_cpu(gdesc->dword[0]) &
> +				 (1UL << VMXNET3_RCD_HDR_INNER_SHIFT)));
> +			BUG_ON(gdesc->rcd.frg &&
> +			       !(le32_to_cpu(gdesc->dword[0]) &
> +				 (1UL << VMXNET3_RCD_HDR_INNER_SHIFT)));
 ...
> +			BUG_ON(!(gdesc->rcd.tcp || gdesc->rcd.udp) &&
> +			       !(le32_to_cpu(gdesc->dword[0]) &
> +				 (1UL << VMXNET3_RCD_HDR_INNER_SHIFT)));
> +			BUG_ON(gdesc->rcd.frg &&
> +			       !(le32_to_cpu(gdesc->dword[0]) &
> +				 (1UL << VMXNET3_RCD_HDR_INNER_SHIFT)));

Just to be clear I'm not applying stuff like this.