linux-kernel - Re: [PATCH] staging: tegra-video: fix V4L2 dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 28 May 2020 15:16:55 -0700
From:   Sowjanya Komatineni <skomatineni@...dia.com>
To:     Arnd Bergmann <arnd@...db.de>, <soc@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>
CC:     Thierry Reding <treding@...dia.com>,
        Dmitry Osipenko <digetx@...il.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-media@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: tegra-video: fix V4L2 dependency


On 5/27/20 3:13 PM, Arnd Bergmann wrote:
> Rather than using a dependency on VIDEO_V4L2, this driver uses
> "select", which fails when other dependencies are missing:
>
> WARNING: unmet direct dependencies detected for VIDEO_V4L2
>    Depends on [n]: MEDIA_SUPPORT [=y] && (I2C [=y] || I2C [=y]=n) && VIDEO_DEV [=n]
>    Selected by [y]:
>    - VIDEO_TEGRA [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && TEGRA_HOST1X [=y]
> (plus an endless stream of link errors for other drivers that
> depend on VIDEO_V4L2 but are now lacking their dependencies)
>
> Fixes: 3d8a97eabef0 ("media: tegra-video: Add Tegra210 Video input driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/staging/media/tegra-video/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/tegra-video/Kconfig b/drivers/staging/media/tegra-video/Kconfig
> index 3f03b5b39e6c..f6c61ec74386 100644
> --- a/drivers/staging/media/tegra-video/Kconfig
> +++ b/drivers/staging/media/tegra-video/Kconfig
> @@ -2,7 +2,7 @@
>   config VIDEO_TEGRA
>   	tristate "NVIDIA Tegra VI driver"
>   	depends on TEGRA_HOST1X
> -	select VIDEO_V4L2
> +	depends on VIDEO_V4L2
>   	select MEDIA_CONTROLLER
>   	select VIDEOBUF2_DMA_CONTIG
>   	help
Acked-by: Sowjanya Komatineni <skomatineni@...dia.com>