linux-kernel - Re: [PATCH] gpiolib: split character device into gpiolib-cdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202005280854.JkKL47mF%lkp@intel.com>
Date:   Thu, 28 May 2020 08:47:49 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Kent Gibson <warthog618@...il.com>, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org, bgolaszewski@...libre.com,
        linus.walleij@...aro.org
Cc:     kbuild-all@...ts.01.org, Kent Gibson <warthog618@...il.com>
Subject: Re: [PATCH] gpiolib: split character device into gpiolib-cdev

Hi Kent,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v5.7-rc5]
[cannot apply to gpio/for-next linus/master linux/master v5.7-rc7 v5.7-rc6 next-20200526]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Kent-Gibson/gpiolib-split-character-device-into-gpiolib-cdev/20200528-000035
base:    2ef96a5bb12be62ef75b5828c0aab838ebb29cb8
config: nios2-allmodconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/gpio/gpiolib-cdev.c:1092:5: warning: no previous prototype for 'gpiolib_cdev_register' [-Wmissing-prototypes]
1092 | int gpiolib_cdev_register(struct gpio_device *gdev, dev_t devt)
|     ^~~~~~~~~~~~~~~~~~~~~
>> drivers/gpio/gpiolib-cdev.c:1110:6: warning: no previous prototype for 'gpiolib_cdev_unregister' [-Wmissing-prototypes]
1110 | void gpiolib_cdev_unregister(struct gpio_device *gdev)
|      ^~~~~~~~~~~~~~~~~~~~~~~

vim +/gpiolib_cdev_register +1092 drivers/gpio/gpiolib-cdev.c

  1091	
> 1092	int gpiolib_cdev_register(struct gpio_device *gdev, dev_t devt)
  1093	{
  1094		int ret;
  1095	
  1096		cdev_init(&gdev->chrdev, &gpio_fileops);
  1097		gdev->chrdev.owner = THIS_MODULE;
  1098		gdev->dev.devt = MKDEV(MAJOR(devt), gdev->id);
  1099	
  1100		ret = cdev_device_add(&gdev->chrdev, &gdev->dev);
  1101		if (ret)
  1102			return ret;
  1103	
  1104		chip_dbg(gdev->chip, "added GPIO chardev (%d:%d)\n",
  1105			 MAJOR(devt), gdev->id);
  1106	
  1107		return 0;
  1108	}
  1109	
> 1110	void gpiolib_cdev_unregister(struct gpio_device *gdev)
  1111	{
  1112		cdev_device_del(&gdev->chrdev, &gdev->dev);
  1113	}
  1114	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (55093 bytes)