linux-kernel - Re: [PATCH] ASoC: AMD: Use mixer control to switch between DMICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f0087d94-c81d-3dc0-9b6d-473795a89918@amd.com>
Date:   Thu, 28 May 2020 10:43:25 +0530
From:   "Agrawal, Akshu" <aagrawal2@....com>
To:     Mark Brown <broonie@...nel.org>,
        Akshu Agrawal <akshu.agrawal@....com>
Cc:     yuhsuan@...omium.org, Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        YueHaibing <yuehaibing@...wei.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@...a-project.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: AMD: Use mixer control to switch between DMICs


On 5/27/2020 4:57 PM, Mark Brown wrote:
> On Wed, May 27, 2020 at 07:10:16AM +0530, Akshu Agrawal wrote:
>
>> +	SOC_SINGLE_BOOL_EXT("Front Mic", 0, front_mic_get, front_mic_set),
> This should probably be a mux with two labelled options, or if it's a
> boolean control it should end in Switch.  A mux definitely seems like a
> better option though.

Actually it's a dmic switch, so will change it to boolean control named 
"DMIC switch". Front or rear mic might change with variants.

Thanks,

Akshu