linux-kernel - Re: [PATCH] vfio/mdev: Fix reference count leak in add_mdev_supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200528090220.6dc94bd7.cohuck@redhat.com>
Date:   Thu, 28 May 2020 09:02:20 +0200
From:   Cornelia Huck <cohuck@...hat.com>
To:     wu000273@....edu
Cc:     kjlu@....edu, Kirti Wankhede <kwankhede@...dia.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Neo Jia <cjia@...dia.com>,
        Dong Jia Shi <bjsdjshi@...ux.vnet.ibm.com>,
        Jike Song <jike.song@...el.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfio/mdev: Fix reference count leak in
 add_mdev_supported_type.

On Wed, 27 May 2020 21:01:09 -0500
wu000273@....edu wrote:

> From: Qiushi Wu <wu000273@....edu>
> 
> kobject_init_and_add() takes reference even when it fails.
> If this function returns an error, kobject_put() must be called to
> properly clean up the memory associated with the object. Thus,
> replace kfree() by kobject_put() to fix this issue. Previous
> commit "b8eb718348b8" fixed a similar problem.
> 
> Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
> Signed-off-by: Qiushi Wu <wu000273@....edu>
> ---
>  drivers/vfio/mdev/mdev_sysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Cornelia Huck <cohuck@...hat.com>