linux-kernel - Re: [git pull] coredump infoleak fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 May 2020 09:44:42 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [git pull] coredump infoleak fix


* Al Viro <viro@...iv.linux.org.uk> wrote:

> On Thu, May 28, 2020 at 09:02:55AM +0200, Ingo Molnar wrote:
> 
> > Looks good to me.
> > 
> > I'm wondering, shouldn't we also zero-initialize the dump data to 
> > begin with? See the patch below (untested).
> 
> Note that this hides the bug from KASAN, though ;-)  And the bug
> is not just infoleak - not all components are "all zeroes" in the
> init state.

Yeah, but is zero-init really a problem though? Wouldn't it be 
'better' to have all zeroes if the dump doesn't fit? But I might be 
missing something ...

Thanks,

	Ingo