[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8592887a502e174b076f16846704fac43885aa5b.camel@nokia.com>
Date: Thu, 28 May 2020 09:06:03 +0000
From: "Sverdlin, Alexander (Nokia - DE/Ulm)" <alexander.sverdlin@...ia.com>
To: "dinghao.liu@....edu.cn" <dinghao.liu@....edu.cn>,
"kjlu@....edu" <kjlu@....edu>
CC: "mpm@...enic.com" <mpm@...enic.com>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
"herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
"ben.dooks@...ethink.co.uk" <ben.dooks@...ethink.co.uk>,
"kstewart@...uxfoundation.org" <kstewart@...uxfoundation.org>,
"arnd@...db.de" <arnd@...db.de>,
"tglx@...utronix.de" <tglx@...utronix.de>,
"yuehaibing@...wei.com" <yuehaibing@...wei.com>,
"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [v2] hwrng: ks-sa - Fix runtime PM imbalance on error
Hello Dinghao,
On Thu, 2020-05-28 at 15:21 +0800, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> the call returns an error code. Thus a pairing decrement is needed
> on the error handling path to keep the counter balanced.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...ia.com>
> ---
>
> Changelog:
>
> v2: - Use pm_runtime_put_noidle() instead of pm_runtime_put_sync().
> ---
> drivers/char/hw_random/ks-sa-rng.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/hw_random/ks-sa-rng.c b/drivers/char/hw_random/ks-sa-rng.c
> index e2330e757f1f..001617033d6a 100644
> --- a/drivers/char/hw_random/ks-sa-rng.c
> +++ b/drivers/char/hw_random/ks-sa-rng.c
> @@ -244,6 +244,7 @@ static int ks_sa_rng_probe(struct platform_device *pdev)
> ret = pm_runtime_get_sync(dev);
> if (ret < 0) {
> dev_err(dev, "Failed to enable SA power-domain\n");
> + pm_runtime_put_noidle(dev);
> pm_runtime_disable(dev);
> return ret;
> }
--
Alexander Sverdlin.
Powered by blists - more mailing lists