linux-kernel - Re: [PATCH] rtc: rv3028: Add missed check for devm_regmap_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <6eb98232-bc84-0854-243a-e54b91f2bda6@web.de>
Date:   Thu, 28 May 2020 11:17:46 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Chuhong Yuan <hslester96@...il.com>, linux-rtc@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Alessandro Zummo <a.zummo@...ertech.it>
Subject: Re: [PATCH] rtc: rv3028: Add missed check for devm_regmap_init_i2c()

> rv3028_probe() misses a check for devm_regmap_init_i2c().

Such information is helpful.


> Add the missed check

Thanks for another completion of the exception handling.


>                      to fix it.

I suggest to replace this wording by the tag “Fixes” for the commit message.
How do you think about to take this possibility into account
for any more patches?

Regards,
Markus