linux-kernel - Re: [PATCH v2] Bluetooth: hci_qca: Improve controller ID info log level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d238c1ac-bcce-28f5-4d74-66e0bc4189c4@codeaurora.org>
Date:   Thu, 28 May 2020 17:31:12 +0800
From:   Zijun Hu <zijuhu@...eaurora.org>
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-bluetooth@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        bgodavar@...eaurora.org, c-hbandi@...eaurora.org,
        hemantg@...eaurora.org, mka@...omium.org, rjliao@...eaurora.org
Subject: Re: [PATCH v2] Bluetooth: hci_qca: Improve controller ID info log
 level



On 5/28/2020 4:16 PM, Marcel Holtmann wrote:
> Hi Zijun,
> 
>> Controller ID info got by VSC EDL_PATCH_GETVER is very
>> important, so improve its log level from DEBUG to INFO.
>>
>> Signed-off-by: Zijun Hu <zijuhu@...eaurora.org>
>> ---
>> drivers/bluetooth/btqca.c | 12 ++++++++----
>> 1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
>> index 3ea866d..94d8e15 100644
>> --- a/drivers/bluetooth/btqca.c
>> +++ b/drivers/bluetooth/btqca.c
>> @@ -74,10 +74,14 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version,
>>
>> 	ver = (struct qca_btsoc_version *)(edl->data);
>>
>> -	BT_DBG("%s: Product:0x%08x", hdev->name, le32_to_cpu(ver->product_id));
>> -	BT_DBG("%s: Patch  :0x%08x", hdev->name, le16_to_cpu(ver->patch_ver));
>> -	BT_DBG("%s: ROM    :0x%08x", hdev->name, le16_to_cpu(ver->rom_ver));
>> -	BT_DBG("%s: SOC    :0x%08x", hdev->name, le32_to_cpu(ver->soc_id));
>> +	bt_dev_info(hdev, "QCA Product ID   :0x%08x",
>> +			le32_to_cpu(ver->product_id));
>> +	bt_dev_info(hdev, "QCA SOC Version  :0x%08x",
>> +			le32_to_cpu(ver->soc_id));
>> +	bt_dev_info(hdev, "QCA ROM Version  :0x%08x",
>> +			le16_to_cpu(ver->rom_ver));
>> +	bt_dev_info(hdev, "QCA Patch Version:0x%08x",
>> +			le16_to_cpu(ver->patch_ver));
> 
> please align correctly according to the coding style.
>
if bt_dev_info() is wrote at one line, it will exceed 80 characters
so i split it at two line and aligned via vim. 
 
> Regards
> 
> Marcel
> 

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project