linux-kernel - Re: [PATCH v4 2/2] gpio: add a reusable generic gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200528100808.GI1634618@smile.fi.intel.com>
Date:   Thu, 28 May 2020 13:08:08 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Michael Walle <michael@...le.cc>
Cc:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v4 2/2] gpio: add a reusable generic gpio_chip using
 regmap

On Thu, May 28, 2020 at 10:46:56AM +0200, Michael Walle wrote:
> Am 2020-05-28 10:37, schrieb Andy Shevchenko:
> > On Thu, May 28, 2020 at 7:11 AM Michael Walle <michael@...le.cc> wrote:
> > > Am 2020-05-28 02:31, schrieb Pierre-Louis Bossart:
> > 
> > 
> > > I've send a v5 with that fix and your names property.
> > 
> > Did you already?
> 
> Yes, I forgot to add you :(
> 
> > Because I have a question why we have gpio-regmap.h instead of
> > gpio/regmap.h ?
> 
> No particular reason, I thought gpio/ was for low level gpio stuff (like
> the consumer.h, driver.h etc) or lets say - more integrated stuff.
> 
> I don't have a strong opinion. I can send a v6 with that change, on
> short notice if the maintainers prefer that location.

I guess it's quite close to core and belongs to GPIO family of headers, I
definitely would like to see it there, but let's wait for Linus and Bart to
speak up.

-- 
With Best Regards,
Andy Shevchenko