linux-kernel - Re: [PATCH net-next 2/4] vmxnet3: add support to get/set rx flow hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202005281829.ltP1BYiw%lkp@intel.com>
Date:   Thu, 28 May 2020 18:39:53 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Ronak Doshi <doshir@...are.com>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <kuba@...nel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 2/4] vmxnet3: add support to get/set rx flow hash

Hi Ronak,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on sparc-next/master linus/master ipvs/master v5.7-rc7 next-20200526]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Ronak-Doshi/vmxnet3-upgrade-to-version-4/20200528-112935
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 50ce4c099bebf56be86c9448f7f4bcd34f33663c
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/net/vmxnet3/vmxnet3_ethtool.c: In function 'vmxnet3_get_rss_hash_opts':
>> drivers/net/vmxnet3/vmxnet3_ethtool.c:704:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
704 |   if (rss_fields & VMXNET3_RSS_FIELDS_ESPIP4)
|      ^
drivers/net/vmxnet3/vmxnet3_ethtool.c:706:2: note: here
706 |  case SCTP_V4_FLOW:
|  ^~~~

vim +704 drivers/net/vmxnet3/vmxnet3_ethtool.c

   667	
   668	static int
   669	vmxnet3_get_rss_hash_opts(struct vmxnet3_adapter *adapter,
   670				  struct ethtool_rxnfc *info)
   671	{
   672		enum Vmxnet3_RSSField rss_fields;
   673	
   674		if (netif_running(adapter->netdev)) {
   675			unsigned long flags;
   676	
   677			spin_lock_irqsave(&adapter->cmd_lock, flags);
   678	
   679			VMXNET3_WRITE_BAR1_REG(adapter, VMXNET3_REG_CMD,
   680					       VMXNET3_CMD_GET_RSS_FIELDS);
   681			rss_fields = VMXNET3_READ_BAR1_REG(adapter, VMXNET3_REG_CMD);
   682			spin_unlock_irqrestore(&adapter->cmd_lock, flags);
   683		} else {
   684			rss_fields = adapter->rss_fields;
   685		}
   686	
   687		info->data = 0;
   688	
   689		/* Report default options for RSS on vmxnet3 */
   690		switch (info->flow_type) {
   691		case TCP_V4_FLOW:
   692			if (rss_fields & VMXNET3_RSS_FIELDS_TCPIP4)
   693				info->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3 |
   694					      RXH_IP_SRC | RXH_IP_DST;
   695			break;
   696		case UDP_V4_FLOW:
   697			if (rss_fields & VMXNET3_RSS_FIELDS_UDPIP4)
   698				info->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3 |
   699					      RXH_IP_SRC | RXH_IP_DST;
   700			break;
   701		case AH_ESP_V4_FLOW:
   702		case AH_V4_FLOW:
   703		case ESP_V4_FLOW:
 > 704			if (rss_fields & VMXNET3_RSS_FIELDS_ESPIP4)
   705				info->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;
   706		case SCTP_V4_FLOW:
   707		case IPV4_FLOW:
   708			info->data |= RXH_IP_SRC | RXH_IP_DST;
   709			break;
   710		case TCP_V6_FLOW:
   711			if (rss_fields & VMXNET3_RSS_FIELDS_TCPIP6)
   712				info->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3 |
   713					      RXH_IP_SRC | RXH_IP_DST;
   714			break;
   715		case UDP_V6_FLOW:
   716			if (rss_fields & VMXNET3_RSS_FIELDS_UDPIP6)
   717				info->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3 |
   718					      RXH_IP_SRC | RXH_IP_DST;
   719			break;
   720		case AH_ESP_V6_FLOW:
   721		case AH_V6_FLOW:
   722		case ESP_V6_FLOW:
   723		case SCTP_V6_FLOW:
   724		case IPV6_FLOW:
   725			info->data |= RXH_IP_SRC | RXH_IP_DST;
   726			break;
   727		default:
   728			return -EINVAL;
   729		}
   730	
   731		return 0;
   732	}
   733	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (61435 bytes)