linux-kernel - Re: [PATCH v2 1/6] mtd: spi-nor: cadence-quadspi: Make driver independent of flash geometry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1873244.LXWL5g5pfh@192.168.0.120>
Date:   Thu, 28 May 2020 11:41:52 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <vigneshr@...com>
CC:     <broonie@...nel.org>, <bbrezillon@...nel.org>,
        <vadivel.muruganx.ramuthevar@...ux.intel.com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <linux-spi@...r.kernel.org>, <simon.k.r.goldschmidt@...il.com>,
        <dinguyen@...nel.org>, <marex@...x.de>
Subject: Re: [PATCH v2 1/6] mtd: spi-nor: cadence-quadspi: Make driver
 independent of flash geometry

On Tuesday, May 26, 2020 12:35:59 PM EEST Vignesh Raghavendra wrote:
> Drop configuration of Flash size, erase size and page size
> configuration. Flash size is needed only if using AHB decoder (BIT 23 of
> CONFIG_REG) which is not used by the driver.
> Erase size and page size are needed if IP is configured to send WREN
> automatically. But since SPI NOR layer takes care of sending WREN, there
> is no need to configure these fields either.
> 
> Therefore drop these in preparation to move the driver to spi-mem
> framework where flash geometry is not visible to controller driver.
> 
> Signed-off-by: Vignesh Raghavendra <vigneshr@...com>
> ---
>  .../mtd/spi-nor/controllers/cadence-quadspi.c | 36 +------------------
>  1 file changed, 1 insertion(+), 35 deletions(-)

Reviewed-by: Tudor Ambarus <tudor.ambarus@...rochip.com>