linux-kernel - Re: [PATCH] MIPS: Fix IRQ tracing when call handle_fpe() and handle_msa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57a8191b-1c64-9a5e-7935-050263d715fb@163.com>
Date:   Thu, 28 May 2020 20:37:28 +0800
From:   yuanjunqing <yuanjunqing66@....com>
To:     tsbogend@...ha.franken.de
Cc:     paulburton@...nel.org, chenhc@...ote.com,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        liulichao@...ngson.cn
Subject: Re: [PATCH] MIPS: Fix IRQ tracing when call handle_fpe() and
 handle_msa_fpe()

sorry!

在 2020/5/28 下午8:35, YuanJunQing 写道:
>  Register "a1" is unsaved in this function,
>  when CONFIG_TRACE_IRQFLAGS is enabled,
>  the TRACE_IRQS_OFF macro will call trace_hardirqs_off(),
>  and this may change register "a1".
>  The changed register "a1" as argument will be send
>  to do_fpe() and do_msa_fpe().
>
> Signed-off-by: YuanJunQing <yuanjunqing66@....com>
> ---
>  arch/mips/kernel/genex.S | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/mips/kernel/genex.S b/arch/mips/kernel/genex.S
> index 8236fb291e3f..a1b966f3578e 100644
> --- a/arch/mips/kernel/genex.S
> +++ b/arch/mips/kernel/genex.S
> @@ -476,20 +476,20 @@ NESTED(nmi_handler, PT_SIZE, sp)
>  	.endm
>  
>  	.macro	__build_clear_fpe
> +	CLI
> +	TRACE_IRQS_OFF
>  	.set	push
>  	/* gas fails to assemble cfc1 for some archs (octeon).*/ \
>  	.set	mips1
>  	SET_HARDFLOAT
>  	cfc1	a1, fcr31
>  	.set	pop
> -	CLI
> -	TRACE_IRQS_OFF
>  	.endm
>  
>  	.macro	__build_clear_msa_fpe
> -	_cfcmsa	a1, MSA_CSR
>  	CLI
>  	TRACE_IRQS_OFF
> +	_cfcmsa	a1, MSA_CSR
>  	.endm
>  
>  	.macro	__build_clear_ade