[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <DA3387FB-670A-4A36-9017-6D1372F9DBC2@gmail.com>
Date: Thu, 28 May 2020 18:24:45 +0530
From: Kaartic Sivaraam <kaartic.sivaraam@...il.com>
To: Junio C Hamano <gitster@...ox.com>
CC: git@...r.kernel.org, Linux Kernel <linux-kernel@...r.kernel.org>,
git-packagers@...glegroups.com
Subject: Re: [ANNOUNCE] Git v2.27.0-rc2
On 27 May 2020 22:17:01 GMT+05:30, Junio C Hamano <gitster@...ox.com> wrote:
>Kaartic Sivaraam <kaartic.sivaraam@...il.com> writes:
>
>> Hi Junio,
>>
>> On 27-05-2020 00:17, Junio C Hamano wrote:
>>> Shourya Shukla (4):
>>> submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb'
>>> gitfaq: files in .gitignore are tracked
>>> gitfaq: fetching and pulling a repository
>>> submodule: port subcommand 'set-url' from shell to C
>>
>> This is the only place where the `set-url` conversion from Shell to C
>> is mentioned. I wonder if it's enough or if it needs a little bit
>more
>> attention may be in the "Performance, Internal Implementation,
>> Development Support etc." as it is a conversion of a submodule
>> sub-command?
>
>I'm not sure if it is worth the bits. It may matter _only_ if/when
>new implementaiton of set-url hurts the end-users by being buggy ;-)
OK. That makes sense. The converted version has gone through reviews and presumably it does pass our CI test cases. I think I was just trying to overcautious to ensure we're not bitten by a worst case scenario wherein a bug slipped through the reviews and the tests. I believe it's pretty unlikely, though :-)
--
Sivaraam
Sent from my Android device with K-9 Mail. Please excuse my brevity and possible "typso".
Powered by blists - more mailing lists