linux-kernel - Re: [PATCH] habanalabs: fix error code in unmap_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf11CwBwHm5MVN6Mg8wXy0O09yKb-RtYqSa4Z3Wv+SrfcvQ@mail.gmail.com>
Date:   Thu, 28 May 2020 16:04:29 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Omer Shpigelman <oshpigelman@...ana.ai>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] habanalabs: fix error code in unmap_device_va()

Thanks, we already have a patch ready for that in -fixes branch that
will be applied in 5.8-rc2
Oded

On Thu, May 28, 2020 at 3:39 PM Dan Carpenter <dan.carpenter@...cle.com> wrote:
>
> Smatch complains that "rc" can be uninitialized on certain paths.
>
> Fixes: 8ff5f4fd40df ("habanalabs: handle MMU cache invalidation timeout")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
>  drivers/misc/habanalabs/memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/memory.c b/drivers/misc/habanalabs/memory.c
> index 4b8eed1ca5130..47da84a177197 100644
> --- a/drivers/misc/habanalabs/memory.c
> +++ b/drivers/misc/habanalabs/memory.c
> @@ -1023,7 +1023,7 @@ static int unmap_device_va(struct hl_ctx *ctx, u64 vaddr, bool ctx_free)
>         struct hl_va_range *va_range;
>         enum vm_type_t *vm_type;
>         bool is_userptr;
> -       int rc;
> +       int rc = 0;
>
>         /* protect from double entrance */
>         mutex_lock(&ctx->mem_hash_lock);
> --
> 2.26.2
>