linux-kernel - Re: [PATCH] ARM: omap2: drop broken broadcast timer hack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 May 2020 06:50:57 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     arm@...nel.org, Rob Herring <robh@...nel.org>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Lokesh Vutla <lokeshvutla@...com>, Keerthy <j-keerthy@...com>,
        Santosh Shilimkar <santosh.shilimkar@...cle.com>,
        linux-kernel@...r.kernel.org, Tero Kristo <t-kristo@...com>,
        Olof Johansson <olof@...om.net>, linux-omap@...r.kernel.org,
        afzal mohammed <afzal.mohd.ma@...il.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: omap2: drop broken broadcast timer hack

* Tony Lindgren <tony@...mide.com> [200528 13:47]:
> * Arnd Bergmann <arnd@...db.de> [200528 09:20]:
> > The OMAP4 timer code had a special hack for using the broadcast timer
> > without SMP. Since the dmtimer is now gone, this also needs to be dropped
> > to avoid a link failure for non-SMP AM43xx configurations:
> > 
> > kernel/time/tick-broadcast.o: in function `tick_device_uses_broadcast':
> > tick-broadcast.c:(.text+0x130): undefined reference to `tick_broadcast'
> 
> Hmm this sounds like a regression though. Isn't this needed for using
> the ARM local timers on non-SMP SoC, so a separate timer from dmtimer?
> 
> I've probably removed something accidentally to cause this.

Sounds like arch/arm/mach-omap2/Makefile change needs to be removed
to always still build in timer.o. And probably timer.c needs back
the ifdef for CONFIG_SOC_HAS_REALTIME_COUNTER.

I'll take a look today.

Regards,

Tony