linux-kernel - Re: [PATCH] efi/esrt: Fix reference count leak in esre_create_sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXE7soPKnsRPjB5HfUZ4MhAVX_ejbidozyOFrj4AfROjPg@mail.gmail.com>
Date:   Fri, 29 May 2020 19:00:34 +0200
From:   Ard Biesheuvel <ardb@...nel.org>
To:     wu000273@....edu
Cc:     kjlu@....edu, Peter Jones <pjones@...hat.com>,
        Matt Fleming <matt.fleming@...el.com>,
        linux-efi <linux-efi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] efi/esrt: Fix reference count leak in esre_create_sysfs_entry.

On Thu, 28 May 2020 at 20:38, <wu000273@....edu> wrote:
>
> From: Qiushi Wu <wu000273@....edu>
>
> kobject_init_and_add() takes reference even when it fails.
> If this function returns an error, kobject_put() must be called to
> properly clean up the memory associated with the object. Previous
> commit "b8eb718348b8" fixed a similar problem.
>
> Fixes: 0bb549052d33 ("efi: Add esrt support")
> Signed-off-by: Qiushi Wu <wu000273@....edu>
> ---
>  drivers/firmware/efi/esrt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
> index e3d692696583..d5915272141f 100644
> --- a/drivers/firmware/efi/esrt.c
> +++ b/drivers/firmware/efi/esrt.c
> @@ -181,7 +181,7 @@ static int esre_create_sysfs_entry(void *esre, int entry_num)
>                 rc = kobject_init_and_add(&entry->kobj, &esre1_ktype, NULL,
>                                           "entry%d", entry_num);
>                 if (rc) {
> -                       kfree(entry);

Why are you removing this kfree() call?

> +                       kobject_put(&entry->kobj);
>                         return rc;
>                 }
>         }
> --
> 2.17.1
>